Change GenericDofMap::cell_dofs(...) return type

[Prof Garth Wells]

Changing the function

const std::vector<dolfin::la_index>& cell_dofs(std::size_t cell_index);

to

const  Array<dolfin::la_index>& cell_dofs(std::size_t cell_index);

would allow the underlying (private) storage type to be changed, with Array just being a view into the data. This can have substantial performance benefits for common cases.

[Jan Blechta]

Why is there a new ArrayView class while Array gives the same functionality?

[Prof Garth Wells]

Because I want ownership to be unambiguous - ArrayView never owns the data.

[Jan Blechta]

I see, but is it worth maintaining twice an amount of SWIG code?

[Prof Garth Wells]

. . . and Array deliberately doesn't have a public copy constructor, which means an object of type Array cannot be returned by a function.

[Prof Garth Wells]

The SWIG code for ArrayView is minimal (much of what is there in the branch will be removed, it was part of trying to get it to 'work').

[Prof Garth Wells]

Implemented in f481d7f.

[Martin Sandve Alnæs]

Removing milestone: 1.6 (automated comment)