DOLFIN include policy

[Jan Blechta]

grep -ir "dolfin_[a-z]*\.h" dolfin/ yields

dolfin/dolfin.h:#include <dolfin/common/dolfin_common.h>
dolfin/dolfin.h:#include <dolfin/parameter/dolfin_parameter.h>
dolfin/dolfin.h:#include <dolfin/log/dolfin_log.h>
dolfin/dolfin.h:#include <dolfin/mesh/dolfin_mesh.h>
dolfin/dolfin.h:#include <dolfin/generation/dolfin_generation.h>
dolfin/dolfin.h:#include <dolfin/geometry/dolfin_geometry.h>
dolfin/dolfin.h:#include <dolfin/refinement/dolfin_refinement.h>
dolfin/dolfin.h:#include <dolfin/graph/dolfin_graph.h>
dolfin/dolfin.h:#include <dolfin/la/dolfin_la.h>
dolfin/dolfin.h:#include <dolfin/nls/dolfin_nls.h>
dolfin/dolfin.h:#include <dolfin/function/dolfin_function.h>
dolfin/dolfin.h:#include <dolfin/math/dolfin_math.h>
dolfin/dolfin.h:#include <dolfin/ale/dolfin_ale.h>
dolfin/dolfin.h:#include <dolfin/fem/dolfin_fem.h>
dolfin/dolfin.h:#include <dolfin/multistage/dolfin_multistage.h>
dolfin/dolfin.h:#include <dolfin/adaptivity/dolfin_adaptivity.h>
dolfin/dolfin.h:#include <dolfin/plot/dolfin_plot.h>
dolfin/dolfin.h:#include <dolfin/io/dolfin_io.h>
dolfin/graph/SCOTCH.cpp:#include <dolfin/common/dolfin_common.h>
dolfin/la/TpetraMatrix.cpp:#include <dolfin/log/dolfin_log.h>
dolfin/la/TpetraVector.h:#include <dolfin/log/dolfin_log.h>
dolfin/la/TpetraVector.cpp:#include <dolfin/log/dolfin_log.h>

dolfin/dolfin.h cases are ok, the rest is not desirable. Remove the instances and write test checking it.

[Jan Blechta]

Fix merged into master at 0e34ce. Could you, @johannes_ring, add make run_styletest to next buildbots. If they stay green, we can merge it into master and add the same test to master bots.

[Jan Blechta]

Of course fix is in next, not in master.

[Jan Blechta]

Further fix in the style test is needed. It does basically nothing when run from build dir and passes green.

[Johannes Ring]

@blechta - I have added make run_styletest to next buildbots now and forced a build.

[Jan Blechta]

Great! Any idea how to get a path to sources rather than by relative path which does not work for a general build dir?

[Johannes Ring]

One way is to rename it to test_coding_style.py.in and use

topdir = "@CMAKE_SOURCE_DIR@"

Then add this in CMakeList.txt:

configure_file(${CMAKE_SOURCE_DIR}/test/codingstyle/test_coding_style.py.in
  ${CMAKE_BINARY_DIR}/test/codingstyle/test_coding_style.py @ONLY)

[Jan Blechta]

Thanks, seems to work well. Pushed to next.

[Jan Blechta]

Next bots are green. Can you add styletest to master bots and merge jan/fix-issue-588?

[Johannes Ring]

Done.

[Jan Blechta]

I had a trouble finding out that it was merged. It should not be fast-forwarded. Next time, please, git merge --no-ff topic. Thanks:)

[Johannes Ring]

Sure. Maybe this should be included on this page?

[Jan Blechta]

Done.

[Jan Blechta]

Seems that cookbook link is stale. There is no hypertext reference to it.

[Jan Blechta]

Fixed that a bit although it would need a further clean-up.