Deprecated MeshGeometry::size() used heavily throught the library

[Jan Blechta]

Annoying symptom is that test stdout is flooded by

Process 0: *** -------------------------------------------------------------------------
*** Warning: MeshGeometry::size() has been deprecated in DOLFIN version 1.7.0.
*** It will be removed from version 1.8.0.
*** Use MeshGeometry::num_vertices() or MeshGeometry::num_points() instead
*** -------------------------------------------------------------------------

[Anders Logg (Chalmers)]

One could use the Event class for this. It has been around for a long time in DOLFIN but is not in much use. However, need to make sure that printing that message many times does not affect performance.

[Prof Garth Wells]

When DOLFIN is built in developer mode, it should should throw a runtime error when the deprecation function is called. Why isn't this being picked up by the tests?

[Jan Blechta]

Seems to me that default is OFF in CMakeLists.txt regardless of build type

option(DOLFIN_DEPRECATION_ERROR "Turn deprecation warnings into errors." OFF)

[Prof Garth Wells]

Just checked, and we had -DDOLFIN_DEPRECATION_ERROR in the old cmake.local file, but towards the end someone switched it off there.

Someone should build DOLFIN and run the tests with -DDOLFIN_DEPRECATION_ERROR=true to clean up all the calls to deprecated code.

[Jan Blechta]

It's Chris' line ba1390e4, that's why assigned to him.

[Jan Blechta]

BTW, I like cmake.local - it's obvious what does it do, compared to fenics-magic-install.sh.

[Chris Richardson]

@blechta - didn't you keep a copy?

[Prof Garth Wells]

@blechta Chris and I and stored copies away in a safe place!!

[Jan Blechta]

I know the place also git checkout `git rev-list -1 HEAD -- cmake.local`^ -- cmake.local :)

[Chris Richardson]

@blechta - now you are just showing off your git mastery... you could just add cmake.local back to the repo and see if anyone notices.

[Prof Garth Wells]

@blechta I now know who to ask next time I have a git question . . .

[Jan Blechta]

I don't know. Garth had a good argument under pull request #214 - cmake.local is non-standard.

[Prof Garth Wells]

Fixed in d296848.

[Anders Logg (Chalmers)]

Removing milestone: 1.7 (automated comment)