Missing return code check of TaoSolve

[Jan Blechta]

https://bitbucket.org/fenics-project/dolfin/src/dd945d70e9a7c8548b4cb88fe8bdb2abe2198b29/dolfin/nls/PETScTAOSolver.cpp?at=master&fileviewer=file-view-default#PETScTAOSolver.cpp-263

Possible cause of this issue http://fenicsproject.org/pipermail/fenics-support/2015-October/001801.html

[Jan Blechta]

@litianyi, can you fix it?

[Tianyi Li]

Maybe I'm missing something, but the error reported there which stops the code is not produced within the file PETScVector.cpp? Anyway it's fairly easy to do the same thing as for SNES.

[Jan Blechta]

This should be done essentially with every PETSc function call which returns error code. See coding style in dolfin/la/PETScFoo.cpp. The pull request does it wrong - thre should be used petsc_error rather then dolfin_error.

[Jan Blechta]

Maybe I'm missing something, but the error reported there which stops the code is not produced within the file PETScVector.cpp?

Yes, but maybe it happens because error in TaoSolve is ignored.

[Jan Blechta]

9e283cc

[Anders Logg (Chalmers)]

Removing milestone: 1.7 (automated comment)