compile failure with clang and debug on

Issue #942 resolved
Chris Richardson created an issue

In MultiMeshFunction.cpp

  // Iterate over meshes from top to bottom                                     
  std::size_t part = multimesh.num_parts() - 1;
  for (;part >= 0; part--)

This code is equivalent to while(true) because part is always >=0. Clang complains about this.

Comments (2)

  1. Chris Richardson reporter

    Also GeometryPredicates::convex_hull_is_degenerate - error: control may reach end of non-void function

    ConvexTriangulation.cpp - error: unused variable 'coplanar_tol' [-Werror,-Wunused-variable] const double coplanar_tol = 1000*DOLFIN_EPS_LARGE;

  2. Anders Logg (Chalmers)

    These should be fixed now (but I haven't built with clang myself yet to confirm there aren't any other issues).

  3. Log in to comment