Test system does ot report/fail on compiler warnings

[Prof Garth Wells]

The tests system does not turn compiler warnings into error, see http://fenics-bamboo.simula.no:8085/download/FFC-FFCDN-RT/build_logs/FFC-FFCDN-RT-48.log. This will cause problem when compiling DOLFIN with FFC generated code.

The FFC regression testing is in a bit of a mess. It uses c-style return codes rather than raising exceptions that can be handled by the testing framework.

See also

• https://bitbucket.org/fenics-project/ffc/commits/507131a559b00abf88a8347784e4d2b5d33db3d3#comment-3446170

• Issue #117

[Jan Blechta]

I think you might be wrong here, Garth. It seems that those are warnings. The error prefix could mean stderr stream.

[Prof Garth Wells]

@blechta You're right.

The unused variable warnings should be turned into errors because they won't allow DOLFIN to be compiled with strict flags.

[Jan Blechta]

But this is different translation unit. FFC output is JITted and linked at runtime.

[Prof Garth Wells]

No via the C++ interface on DOLFIN.

[Jan Blechta]

Ok, you mean DOLFIN programs (demos).

[Prof Garth Wells]

Yes.

[Prof Garth Wells]

Edited title and description to accurately reflect issue.

[Prof Garth Wells]

Issue #117 was marked as a duplicate of this issue.

[Martin Sandve Alnæs]

Is this still an issue? The uflacs unused-variables are fixed and I'm adding -pedantic back for uflacs regressions.

[Martin Sandve Alnæs]

Marking this as resolved. Open a new issue if there's a more specific problem that remains.