Call ffc.main in regression and units tests instead of commandline ffc
It's a fairly simple change to run ffc.main([args...])
instead of using subprocess, except I don't know off the top of my head how to best capture the output. Can probably register a logger to write to file instead of capturing stdout.
This will give a significant boost in regression test performance, as witnessed by similar change in dolfin generate-form-files.
Comments (10)
-
-
Related: https://bitbucket.org/fenics-project/ffc/issues/62
Would be good if we could run test via pytest.
-
reporter -
assigned issue to
-
assigned issue to
-
reporter If we run via pytest, do we need to mess with capturing the output? py.test does that by default and just add -s to see it.
-
-
reporter @johannes_ring progress on the output capture?
(to others reading: his branch works but output filtering needed some more polish)
-
@martinal - no, no progress yesterday. Feel free to take a look.
-
- changed status to resolved
Fixed via pull request #47.
-
Do we now run FFC tests with Py3 on Bamboo?
-
No, not yet, but I hope I can add that today.
- Log in to comment
We can't test with py3 on pipelines until we get this sorted.