Development version numbering is not PEP440 conform
Recent versions of setuptools complain that the fenics python packages are not PEP 440 conform [0]:
/home/ml/.local/lib/python2.7/site-packages/pkg_resources/init.py:2510: PEP440Warning: 'FFC (1.5.0-)' is being parsed as a legacy, non PEP 440, version. You may find odd behavior and sort order. In particular it will be sorted as less than 0.0. It is recommend to migrate to PEP 440 compatible versions.
This warning always appears when installing any python package via its setup.py script using setuptools when one of the fenics python packages is installed. Incidentally, the warning does not appear when installing any fenics python package as these only rely on distutils.
According to [0] a PEP440 conform version number for 1.5.0+ would be 1.6.0dev.
Although I only submit this for FFC, this also applies to instant, fiat, and ufl.
[0] https://www.python.org/dev/peps/pep-0440/#development-release-separators
Comments (5)
-
-
Sounds good. @mliertzer Could you make a pull request?
-
reporter Yes, I can make one later today.
I guess for consistency I should also increase the version number of dolfin, although the RELEASE preprocessor string was used in a different way up to now. However, it wasn't set for the latest release anyway [0], so this shouldn't really affect anyone.
[0] https://bitbucket.org/fenics-project/dolfin/commits/376dc2f223cb47291c311c1f3a69898d27c4538f
-
Isn't this fixed?
-
- changed status to resolved
Yes, this was fixed in bdaba2.
- Log in to comment
Pep conforming is good, we should switch then.