functional.py has old Scientific Python code

Issue #12 resolved
Prof Garth Wells created an issue

functional.py has used AD code from Scientific Python which is no longer imported by FIAT. Code must be non-functional.

Comments (4)

  1. Miklós Homolya

    This is unfortunately, but unsurprisingly causing flake8 errors. However, if we want to enable flake8 in the continuous integration system, then the code must be made flake8 clean, otherwise the build will constantly be red. I'm wondering which of these options is better:

    1. Remove offending code. Since the code is already broken, it is safe to assume that currently no one uses it.
    2. Fix the problematic code. This would be nice, however, it would take time and effort, while no one seems to need it at the moment.
    3. Comment out broken code. This could make sense if we expected that someone would need this functionality in the future, and that the current broken code is a good basis for producing working code.
    4. Give up enabling flake8 in CI.

    Edit: @David_Ham has attempted to fix some of these in https://github.com/firedrakeproject/fiat/pull/3.

  2. Log in to comment