functional.py has old Scientific Python code
Issue #12
resolved
functional.py
has used AD code from Scientific Python which is no longer imported by FIAT. Code must be non-functional.
Comments (4)
-
-
reporter I suggest removing it.
-
Offending code was removed in pull request #11.
-
- changed status to resolved
- Log in to comment
This is unfortunately, but unsurprisingly causing flake8 errors. However, if we want to enable flake8 in the continuous integration system, then the code must be made flake8 clean, otherwise the build will constantly be red. I'm wondering which of these options is better:
flake8
in CI.Edit: @David_Ham has attempted to fix some of these in https://github.com/firedrakeproject/fiat/pull/3.