Gradient tabulation bug-fix for the trace element
Thomas Gibson
Branch: mapdes/fiat:hdivtrace-gradient-fix
Branch: fenics-project/fiat:master
Merged
Merged pull request
Merged in mapdes/fiat/hdivtrace-gradient-fix (pull request #31)
Merged in mapdes/fiat/hdivtrace-gradient-fix (pull request #31)
This PR is made in response to a bug (detailed in GitHub FIAT Issue 7) that was discovered while testing the
TraceError
handling when asking for derivatives on a trace element. A small change was made inhdiv_trace.py
to make sure dict keys are accurate and hence theTraceError
is inserted properly.I also made the unit test
test_hdivtrace.py
more thorough: it tests on 2D and 3D reference simplex cells and tests forTraceError
instances where appropriate.