Gradient tabulation bug-fix for the trace element

Merged
#31 · Created  · Last updated

Merged pull request

Merged in mapdes/fiat/hdivtrace-gradient-fix (pull request #31)

5bdea9e·Author: ·Closed by: ·2016-11-05

Description

This PR is made in response to a bug (detailed in GitHub FIAT Issue 7) that was discovered while testing the TraceError handling when asking for derivatives on a trace element. A small change was made in hdiv_trace.py to make sure dict keys are accurate and hence the TraceError is inserted properly.

I also made the unit test test_hdivtrace.py more thorough: it tests on 2D and 3D reference simplex cells and tests for TraceError instances where appropriate.

0 attachments

0 comments

Loading commits...