Add access to more geometry quantities through ufl

Issue #12 resolved
Martin Sandve Alnæs created an issue

Done:

  • Adding expression types

Todo:

  • Updating algorithms in UFL
  • Updating algorithms in form compilers
  • Generating code in form compilers
  • Eventual convenience updates in PyDOLFIN

Comments (18)

  1. Martin Sandve Alnæs reporter

    I've added some types and here's the full list now:

            SpatialCoordinate
            LocalCoordinate (where applicable)
    
            Jacobian (currently affine but should represent non-affine later)
            JacobianDeterminant
            JacobianInverse ((pseudo-)inverse of Jacobian)
    
            FacetJacobian (currently affine but should represent non-affine later)
            FacetJacobianDeterminant
            FacetJacobianInverse ((pseudo-)inverse of Jacobian)
    
            CellVolume
            Circumradius
    
            FacetArea
            MinFacetEdgeLength
            MaxFacetEdgeLength
    
            FacetNormal
    

    Just need to get all into ffc.

  2. Martin Sandve Alnæs reporter

    Anyone need CellSurfaceArea and FacetDiameter? They're not implemented in ffc, I think I might remove them from ufl.

  3. Martin Sandve Alnæs reporter

    Jacobian* are maybe not well defined? In cell integrals all is fine but for exterior and interior facet integrals maybe we need to have CellJacobian vs FacetJacobian.

  4. Martin Sandve Alnæs reporter

    The names above are not the final ones. I've tried to at least improve the docstrings of the new types, although there's still room for better documentation.

  5. Martin Sandve Alnæs reporter

    Closing this because it's too broad. A bunch of such quantities are now available when using uflacs, and the full pipeline is tested in a dolfin unit test. I have no intention of making all available in vanilla ffc. Create a new issue if anything in particular is needed.

  6. Log in to comment