- changed title to Add access to more geometry quantities through ufl
Add access to more geometry quantities through ufl
Done:
- Adding expression types
Todo:
- Updating algorithms in UFL
- Updating algorithms in form compilers
- Generating code in form compilers
- Eventual convenience updates in PyDOLFIN
Comments (18)
-
reporter -
reporter - marked as major
-
- changed milestone to 1.4
-
reporter -
assigned issue to
-
assigned issue to
-
reporter I've added some types and here's the full list now:
SpatialCoordinate LocalCoordinate (where applicable) Jacobian (currently affine but should represent non-affine later) JacobianDeterminant JacobianInverse ((pseudo-)inverse of Jacobian) FacetJacobian (currently affine but should represent non-affine later) FacetJacobianDeterminant FacetJacobianInverse ((pseudo-)inverse of Jacobian) CellVolume Circumradius FacetArea MinFacetEdgeLength MaxFacetEdgeLength FacetNormal
Just need to get all into ffc.
-
Where are these documented/listed (except for on this page)?
-
reporter Listed in ufl docstring, but the documentation is not good enough.
-
reporter Anyone need CellSurfaceArea and FacetDiameter? They're not implemented in ffc, I think I might remove them from ufl.
-
reporter Jacobian* are maybe not well defined? In cell integrals all is fine but for exterior and interior facet integrals maybe we need to have CellJacobian vs FacetJacobian.
-
reporter - edited description
-
reporter - marked as critical
-
reporter - changed milestone to 1.5
Good progress, won't be completed for 1.4.
-
reporter The names above are not the final ones. I've tried to at least improve the docstrings of the new types, although there's still room for better documentation.
-
reporter - removed milestone
-
reporter - removed responsible
-
reporter -
assigned issue to
- changed milestone to 1.7
- changed version to dev
-
assigned issue to
-
reporter - changed status to resolved
Closing this because it's too broad. A bunch of such quantities are now available when using uflacs, and the full pipeline is tested in a dolfin unit test. I have no intention of making all available in vanilla ffc. Create a new issue if anything in particular is needed.
-
reporter - removed milestone
Removing milestone: 1.7 (automated comment)
- Log in to comment