1. Peter Ward
  2. reboot/mud-tutorials

Pull requests

#1 Merged
Repository
aragilar
Branch
default
Repository
flowblok
Branch
default

Added start keyword to json in stage 1.

Author
  1. James Tocknell
Reviewers
Description

I presume you'd like suggestions as pull requests. It would make sense to be able to change the start position, so I added start to special for the main hall in stage 1.

  • Learn about pull requests

Comments (3)

  1. Peter Ward repo owner

    Yes, thanks. Yes, it makes sense to be able to change it, but it doesn’t make sense for it to be a special attribute: what happens if I have two rooms both labelled as "start"? I think adding it as a new top-level key would be okay, though (which would get rid of the rearrangement done in stage 2).

  2. Peter Ward repo owner

    The bit at the end of stage 2 needs to be updated to reflect the changes here, but that's not blocking this change.

    I pressed the "Approve" button, that may give you magical permissions to merge this? Otherwise, I'll merge it when I next get a chance to work on it.