#1 Merged
Repository
slide_o_mix
Branch
default
Repository
fmoo
Branch
default
Author
  1. Alex Earl
Reviewers
Description

Added parameter to the authorize method to allow for a callback to be passed which will be used to retrieve the verification code from the user. This will allow someone using the library in a UI to provide an input dialog for the user to input the verification code. There is a default version provided which maintains the current behavior (console input of verification code).

Comments (3)

  1. Peter Ruibal repo owner

    Looks good, but I can you move _defaultGetVerifierCallback() to module scope and call it _default_get_verifier_callback()?

    I would rather have the function in the module scope than a method on a class without self as the first parameter.

    Also, can you fix the whitespace on line 44? "token,callback" should be "token, callback"

    Thanks for fixing line 38 btw, I wrote this before I had a PEP8 linter.

  2. Peter Ruibal repo owner

    Hey, so I'd like to add a LICENSE and an AUTHORS file here. Would it be OK if I use BSD for the LICENSE as well as your real name / email address in the AUTHORS file? lmk