2018-01-23 Marcus Hinz - First Pull Request - Windows build

Merged
#1 · Created  · Last updated

Merged pull request

Merged in marcus-hinz/tractatus-marcus-playground/windows-build (pull request #1)

00eb187·Author: ·Closed by: ·2018-01-23

Description

Hi Kevin,

my first pull request.

I set up a windows build for the html versions.

As I work on Linux as well as on MS Windows it's necessary for effective work.

Please be aware of 2 commits: I replaced the use of the constant PHP_EOL by a "\n" when Russell's introduction is split into paragraphs (TEST * ms windows compatibility problems). I introduced a new constant for "\n" that I do not know where to put. I am absolutely not a PHP guy. Maybe you know better how to handle the issue.

Tested on my Linux and MS Windows systems.

Next to follow: Preference store for the settings.

I hope that's fine for you. In case of any problems just let me know.

Regards Marcus

PS: the repo is private now :-)

  • IMPLEMENTED * create new build script for ms windows

    make_ ... creates both html versions of the tractatus tail.cmd is just a bogus script to avoid unnecessary error messages.

  • TEST * ms windows compatibility problems.

    there seems to be a problem with the PHP_EOL constant in the code. when tex is converted to html the code implicitly assumes that the system value of eol (as reflected in the constant PHP_EOL) is “\n”. on windows systems it’s not. if the eol delivered by the vcs is “\n” one cannot use the PHP_EOL to reference the eol delivered by the vcs, as the actual value of PHP_EOL changes the value delivered by the vcs does not. A test whether we got this thing working cross OS.

  • IMPLEMENTED * introduce constant to reflect eol delivered by vcs

    as i am a chinese room when dealing with php code i do not have the faintest idea how to introduce the constant in the right way. it should be declared on the highest possible level an used throughout the whole project in consintent manner.

  • FIXED * code readability

    this change is not exactly necessary. still it took me some time to figure out what the old code was doing. thus it took me even more time to see where the compatibility issue with windows was.

  • IMPLEMENTED * use installed php.

    a path to the php executable is no longer set in the build script. the script is easier to use this way. on the other hand hand the script expects that php is properly installed on the system.

  • IMPLEMENTED * do not delete TEMP_DIR when cleaning up

0 attachments

0 comments

Loading commits...