Commits

fs  committed 00d6344

Added handling of invalid cookie names by responding with 400 Bad Request (#868, backport of r2175)

  • Participants
  • Parent commits 890172a
  • Branches cherrypy-2.x

Comments (0)

Files changed (2)

File cherrypy/_cphttptools.py

             # Handle cookies differently because on Konqueror, multiple
             # cookies come on different lines with the same key
             if name.title() == 'Cookie':
-                self.simple_cookie.load(value)
+                try:
+                    self.simple_cookie.load(value)
+                except Cookie.CookieError:
+                    msg = "Illegal cookie name %s" % value.split('=')[0]
+                    raise cherrypy.HTTPError(400, msg)
         
         # Save original values (in case they get modified by filters)
         # This feature is deprecated in 2.2 and will be removed in 2.3.

File cherrypy/test/test_core.py

                           ])
             self.assertHeader('Set-Cookie', 'First=Dinsdale')
             self.assertHeader('Set-Cookie', 'Last=Piranha')
+            
+            self.getPage("/cookies/single?name=Something-With:Colon",
+                [('Cookie', 'Something-With:Colon=some-value')])
+            self.assertStatus(400)
         else:
             self.getPage("/cookies/single?name=First",
                          [('Cookie', 'First=Dinsdale;')])