Anonymous avatar Anonymous committed e4318d1

Fixed #312

Comments (0)

Files changed (1)

cherrypy/lib/filter/sessionfilter.py

                         yield line
             except:
                 # Can't use try/finally because of yield
-                self._clean(sess)
+                self._clean()
                 raise
-            self._clean(sess)
+            self._clean()
         
         sess = cherrypy.request._session
         if not sess.sessionStorage:
         # Make a wrapper around the body in order to save the session
         #   either before or after the body is returned
         cherrypy.response.body = saveData(cherrypy.response.body, sess)
+
+    def onEndResource(self):
+        # If RequestHandled is raised, beforeFinalize and afterErrorResponse
+        #   are not called, so we release the session here
+        self._clean()
+
+    def afterErrorResponse(self):
+        self._clean()
     
-    def afterErrorResponse(self):
+    def _clean(self):
         sess = cherrypy.request._session
-        if not sess.sessionStorage:
+        if not getattr(sess, 'sessionStorage', None):
             # Sessions are not enabled: do nothing
             return
-        self._clean(sess)
-    
-    def _clean(self, sess):
         if getattr(sess, 'locked', None):
             # If the session is still locked we release the lock
             sess.sessionStorage.releaseLock()
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.