pass removed from valid moves sometimes

Issue #45 resolved
dsmic created an issue

It is difficult to reproduce. e.g. When I saw this in a KGS game I restarted the engine and oakfoam passed immediatly.

I had a look at makeMove around line 570. To me it seems, that the handling of pass is missing after this. It seems even calling clear with -1?!

But I might be wrong. I would expect this to cause more trouble?!

Comments (3)

  1. dsmic reporter

    Might have been a handicap bug. Not on all places handicap stones were taken into account for scoring.

    Please have a look at the code problem I have mentioned. If you think this is my fault, please do the bug on hold, I will test if the problem was really handicap related!

  2. Francois van Niekerk repo owner

    Pass should always be added to the tree and it should never be removed. Why do you say that pass was removed from valid moves?

    I had a look at Go::Board::makeMove() around line 570, but I'm not quite sure what you are referring to. If the move made is a pass or resign, it is handled around line 534.

  3. Log in to comment