Pull requests

#3 Open
Repository
dancechaser dancechaser
Branch
default
Repository
frankban frankban
Branch
default

Fixed issue #16 (show_starrating now renders properly for multiple ratings on the same object)

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update 
hg pull -r default https://bitbucket.org/dancechaser/django-generic-ratings
Author
  1. Tai Vo
Reviewers
Description

This fix addresses a more general problem than issue #16. Before this fix, multiple renderings of star widgets for the same score do not work. All the container divs of those star widgets end up with the same HTML id so only the first div gets rendered properly.

With this fix, I introduced a creation counter to BaseWidget and used that counter to ensure HTML ids are unique.

The usecase that brought this to my attention involves 1 readonly star widget to display a score and 1 star widget in a modal form for voting purpose.

Comments (0)