New Sets Do Not Clear Out Unused Attributes

Issue #306 closed
Timothy Weaver created an issue

I have used Sets to process a queue of TV show episodes. When I create a new Set for a different TV show, attributes from the first Set that are not used in the second Set are still present in the new file's meta data.

To reproduce:

  1. Create a Set for TV Show 1. I used Strangers with Candy, which has a Screenwriters attribute. Process some episodes using the Queue batch processing.

  2. Create a Set for TV Show 2. I used The Detour, which does not have a Screenwriters attributes. Process some episodes using the Queue batch processing.

  3. The episodes for TV Show 2 will include the Screenwriters attribute from TV Show 1.

It appears that the code is using "left over" attributes from the first set that are not explicitly overwritten with new values from the second set.

Comments (8)

  1. Damiano Galassi repo owner

    Right now sets are merged to the existing metadata items. In a future version I will add a way to select the behaviour to either merge or replace.

  2. Damiano Galassi repo owner

    I think I didn't read understand this issue the first time I read it. So you have to sets, and when you apply the second one you get things from the first set?

  3. Timothy Weaver reporter

    Hi, I think your first answer on 2-14 was the right understanding. Apply a Set only merges new attributes or replaces values of existing attributes. I do not think it matters whether the first set of attributes were applied through a Set, only that they already exist on the file.

  4. Timothy Weaver reporter

    I would propose that if you are using a Set to apply the attributes, it should replace 100% of the existing attributes. Perhaps there could be an option when creating / configuring a Set called "Replace All Attributes". If that option is set, then it replaces 100%. If that option is not set, it only replaces values for attributes configured in the new Set.

  5. Damiano Galassi repo owner

    That was added in 1.3.6, if you go to Preferences -> Preset you can edit the presets to remove the existing metadata.

  6. Log in to comment