Subtitles Stop Working

[Scott Sharritt]

I've noticed that with the latest release that if I have an .mkv file with the subtitle file already embedded the subtitles stop working about halfway through the video. If I watch the .mkv file through VLC I have fully working subtitles. But once I convert the file and import it into iTunes after a few minutes of working the subtitles just stop. I get no errors during conversion and toggling the subtitles off then on doesn't fix the issue. I've only seen this with .mkv files so far that have an embedded subtitle file. If I add an external file everything works fine.

[Damiano Galassi]

Please send me a .mkv to reproduce the issue. If not, it would be hard to fix.

[Scott Sharritt]

The only example I currently have is about 2GB in size. How would I get that over to you?

[Damiano Galassi]

Upload it to dropbox/googledrive/onedrive/whatever and send me the link.

[Damiano Galassi]

Does it happens with older versions of Subler too? I tried your file but subtitles works all the time.

[Scott Sharritt]

Subtitles worked fine prior to ver 1.4.1 and work fine for external .srt files in 1.4.1. It is only in subtitles embedded in .mkv files in the new version that I'm having the issue with.

[Damiano Galassi]

Which version of macOS/iTunes are you running?

[Scott Sharritt]

OSX El Capitan 10.11.6 and iTunes 12.7.0.166

[Scott Sharritt]

I should also say once converted the file .mp4 or .m4v also doesn’t have working subtitles in VLC even though they work in VLC on the .mkv version of the file.

[Damiano Galassi]

Still can't reproduce it, both version of Subler creates exactly the same subtitles data. Can you send me the non working mp4 file too?

[Scott Sharritt]

Uploading the file now. I’ll post the link as soon as it finishes. Thanks for looking into this!

[Scott Sharritt]

Here's the link:

[Damiano Galassi]

Your file contains only ~2 minutes of subtitles. Maybe there is a race condition somewhere, I'll check the code later.

[Damiano Galassi]

Found a stupid logic error, maybe it's the culprit.

[Damiano Galassi]

Should be fixed now, try https://subler.org/downloads/Subler-Test.zip

[Scott Sharritt]

Okay, tried the same two files I still had (including sample sent to you) and a brand new .mkv and they all seem to work perfectly now. Thanks!

[Scott Sharritt]

I've tested ten new files, all work as expected in the new version. Of those, I converted five with the previous version and each had subtitles that stopped working at some point. Looks like the logic error you fixed did the job!