1. Michael Granger
  2. ruby-pg
  3. Issues

Issues

Issue #95 resolved

Include st.h when using st_* functions

Anonymous created an issue

In MRI, st.h is included in intern.h which is included in ruby.h. However, we do not include st.h in Rubinius. Since st_* functions are used, st.h should be explicitly included.

Alternatively, I'd suggest not using st_* functions at all. They are very much an implementation detail of MRI.

The include of st.h is the only blocker for building the pg gem under Rubinius 1.9 mode:

https://gist.github.com/1489400

Thanks, Brian

Comments (8)

  1. Michael Granger repo owner

    I'm happy to accept a patch that replaces the use of st_* functions, and works under MRI (1.8.7 and 1.9.3), JRuby, and the latest Rubinius (in both 1.8 and 1.9 modes).

    In the meantime, I'll add an include for st.h.

  2. Anonymous

    Any chance of a minor release with this fix? It'd be a nice Christmas present for Rubinius users :)

  3. Log in to comment