1. Geert Jansen
  2. winpexpect

Pull requests

#1 Open
Repository
windwiny
Branch
default
Repository
geertj
Branch
default

test some change

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update 
hg pull -r default https://bitbucket.org/windwiny/winpexpect
Author
  1. windwiny
Reviewers
Description
No description
  • Learn about pull requests

Comments (2)

  1. Geert Jansen repo owner

    Hi, thanks for the pull request. Some questions:

    • Why did you comment out the test in test_cmdline?
    • Can we assume SystemRoot is always set?

    Also when you submit a pull request please ask me to pull a clean patch. In this case probably it should be one patch only, with an appropriate description.

    1. windwiny author

      Hi,

      • I test on win7 x86, test_cmdline.py line52 , join_command_line(['a|b']) == 'a|b', not '"a|b"', Maybe it's a bug?
      • SystemRoot exists in winXP,win7, maybe it also exists other win32.