Error when editing "internalType" of a weapon (solved - delete)

[JAsmine-ja2 NA]

issue solved - delete

When changing the "internalType" in weapons.json of a weapon, the game doesn't start. This makes modding the weapons very difficult. I tried to change itemIndex 22 (Mini-14) from RIFLE to ASRIFLE.

File build/lib_rapidjson/rapidjson/document.h, Line 422 Expression: flags & kIntFlag

Screenshot of detailed error message is attached. v 0.12.352-win

[Stefan Lau]

I cannot reproduce this, I can change the internalType without any issue. To be fair I didn't try this with the MINI-14 but with the HK-21 by changing the type from LMG to ASRIFLE on current master.

[JAsmine-ja2 NA]

I investigated the issue. The problem is, that when you change the internalType of a gun from a weapon without burstfire (e.g. rifle, pistol) to one with burstfire (e.g. m_pistol, asrifle) you HAVE to add ubShotsPerBurst ubBurstPenalty BurstSound": "sounds/weapons/bursttype1.wav in the index in weapons.json. If you don't add them, the game won't start. Issue solved. :)

[Stefan Lau]

But this should still throw an error or something, which would ease development for modders (they should be made aware of what was done wrong).

[Gennady Trafimenkov]

Well... maybe later there will be a better error handling for such cases