Resfinder's call to get latest commit ID creates problems for pipelines with multiple users

Issue #123 resolved
Ryan James Kennedy created an issue

When resfinder initiates its database, it retrieves the git versioon commit using get_version_commit from pliers_mixin.py. Problems arise when Resfinder is used in a (nextflow) pipeline by multiple users as git has problems with this. Is there a particular reason you retrieve the commit when you have a VERSION file already?

Comments (3)

  1. RolfKaas

    Hi Ryan. In the current version of ResFinder, the version information is stored in src/resfinder/__init__.py, but the version is only referring to the latest release version of ResFinder, not the specific commit. The commit information is used for when people are running unreleased versions of ResFinder, typically developers. You should not run a cloned version of ResFinder in production. The recommended way is either pip or our released docker images from Docker Hub: https://hub.docker.com/r/genomicepidemiology/resfinder. If you run one of those, you should not experience any git issues.

  2. Log in to comment