no default for csw_url in current dev (2.13.1)

[Dominik Fröhlich]

In the current dev (2.13.1) a default value for csw_url is not set, so metadata is not requested if csw_url is not set explicitely in every layer def in the services.json.

In case there is nor csw_url defined in services.json, the csw url from the rest-services could be used as a default. Otherwise we have to set the exact same url for most of the layers (what was not necessery for the older versions (tested with 2.8.0)).

The issue arises from /modules/layerInformation/store/actionsLayerInformation.js::111ff

else if (metaInfo.cswUrl !== null && typeof metaInfo.metaId !== "undefined") {
    metadata = await getRecordById(metaInfo.cswUrl, metaInfo.metaId);
}

lacking another else if only checking for typeof metaInfo.metaId !== "undefined" and applying the csw url from the rest-serives.json.

Best,

Dominik

[Christopher Reder]

Hello Mr Fröhlich, Thank you very much for pointing out the error and suggesting a solution. You are welcome to implement this in the form of a pull request and send it to us.

With kind regards Christopher Reder

[Dominik Fröhlich]

My user unfortunatelly is lacking permission to open pull requests…

Best,

Dominik

[Christopher Reder]

To create a pull request, you need to make it from your fork on the master portal. You can find the instructions for creating pull requests in our md file for the git workflow. https://bitbucket.org/geowerkstatt-hamburg/masterportal/src/dev/doc/gitWorkflow.md

[Dominik Fröhlich]

I see. i was confused by the mouseover telling me I don’t have permission to create a pull request.

I’ll create a fork and retry. Thanks!

[Dominik Fröhlich]

Issue should be resolved already…

[Dominik Fröhlich]

Resolved by PR 2958