1. Boris Glimcher
  2. hgcr-gui

Wiki

Clone wiki

hgcr-gui / Home / FAQ

FAQ

Q: As a reviewer, is the expectation that I place my comments directly into the code (e.g. as a comment itself), or is there a way to attach the comments as metadata?

A: The review on the code is usually done inside the code. Each organization has it's own review conventions. I, for example, put review line as a comment before reviewed line with my name attached to it (you can actually see it inside the extension code)

# CR Boris: use more meaningful var names 
i=2 

----------------

Q: As the developer, how do I respond to the comments?

A: Developer fixes the issue in the code and removes my CR. If the developer has any question (Q) or disagrees with the review, he can put it's own answer (A) after the CR line.

# CR Boris: use more meaningful var names 
# A Dima: this name is good 
# Q Sergei: do you mean very good?? 
i=2 

----------------

Q: As an administrator, how do I verify that a specific file has been reviewed and that the developer and reviewer reached agreement on the reported issues (e.g. that the developer did not simply close the review process ignoring one or more of the reviewer's comments).

A: If HGCR reports review is done, than reviewer finished the *current* round of review. The number of round can be set by administrator.

The "final say" if review will be accepted or not is on the developer... So if the developer decides to leave some things untouched, the review will still be DONE.

----------------

Updated