voronoi.Voronoi. computeNeighbors index out of range bug
Issue #125
resolved
File "analyze.py", line 18, in analyze_first_coordinate_shell v.computeNeighbors(positions=lattice.particles.position[:]); File "/Users/Paul/local/freud/voronoi.py", line 101, in computeNeighbors self.firstShellNeighborList[ridge_points[k,1]] = self.firstShellNeighborList[ridge_points[k,1]] + [ridge_points[k,0]] IndexError: list index out of range
Comments (13)
-
reporter
-
@the_real_pdodd status?
-
reporter
Yeah I have it all fixed. are there any unit tests for this calculation?
-
test_voronoi.py. Run with nosetests
-
reporter
will do.
-
Updates?
-
@the_real_pdodd Do you know if this been fixed and/or resolved by the new neighbor list?
-
reporter
@bdice I have not looked at the new neighbor list code. So I am not sure. There were other issue beyond this one and I am willing to take a look into it and see if the changes I made are obsolete now.
-
reporter
- edited description
-
assigned issue to
Paul Dodd
-
@the_real_pdodd Before you do a lot of work on this, it might be good to look at the discussion on PR 117. It may be closely related or supersede the code that caused this problem (not sure). Matthew updated this PR recently, and I fixed some (but not all) tests. https://bitbucket.org/glotzer/freud/pull-requests/117
-
reporter
yeah I looked at that last night. looks like that does have some of the changes that I made as well.
-
These are the changes that you made on the voronoi_fix branch, correct? So after we merge PR 117 we can close this issue and delete the voronoi_fix branch, is that right?
-
- changed status to resolved
See Pull Request #17
- Log in to comment
I have this mostly solved (i think) I am testing now.