1. Andrew Gough
  2. premake-dev-d
  3. Issues
Issue #5 resolved

Still no pull request...

Manu Evans
created an issue

There's a few of us really keen for this to make back to the mainline! :)

This fork is fairly out of date now.

Comments (8)

  1. Andrew Gough repo owner

    Hey Manu,

    You're right - the fork is out of date. I wasn't aware there were a lot of people interested (but its cool that someone does). When I initially added D support, I provided the following patches on the sourceforge patch tracker:

    http://sourceforge.net/tracker/?func=detail&aid=3458189&group_id=71616&atid=531880 http://sourceforge.net/tracker/?func=detail&aid=3458646&group_id=71616&atid=531880

    This was how starkos wanted contributions delivered. Obviously they have sat there for a long time and suffered bitrot - along with a whole bunch of other patches (there are 55 still open). I am unsure how to get changes delivered to mainline otherwise. I understand he doesn't like pull requests but that could have changed.

    I'd be more than happy to do the updates to head, and open a pull request, but the feeling I get is it will stall again anyway. And I don't have the time or inclination to maintain a fork indefinitely.

    Any suggestions?

  2. Manu Evans reporter

    Really? Doesn't like pull requests? ... That's weird :/

    Well, if you want to update it once, then I work with a few guys that'll be able to use it, and perhaps a group of us can pressure him to accept the pull request ;) .. Otherwise, I can try and keep it up to date. It shouldn't be much trouble after the initial update.

    From looking at recent commits, it looks like the gmake action was renovated (preparing for premake5?), so the initial update might not be trivial.

    I really should take some time to get comfortable with Lua... I tend to just wing it :/

  3. Andrew Gough repo owner

    ok cool - I'll give an update a go and open a pull request. I'd really like to see this in the mainline rather than here. I'd better have another look at hellknights fork as I did merge those changes a while back - he may have more, though.

    I probably won't get a chance to look at it properly til the weekend, but once I get it in shape, I'd really appreciate your input going forward. These things die easily if only one person supports it.

  4. Manu Evans reporter

    Well assuming I get a build that works, I'll be using it on a regular basis, and I regularly update premake, so I'll keep my eye on it.

    Hopefully starkos merges it though. I presume part of your work was to define the concept of the D language in premake, which I might try and use to add VisualD support aswell...

  5. Log in to comment