Commits

Grant Eagon committed f4351e6 Draft

Better validation for use of the "in" keyword. Now ignores quoted strings.

Comments (0)

Files changed (2)

Syntaxes/HTML (Liquid).tmLanguage

 						<key>name</key>
 						<string>constant.language.liquid</string>
 					</dict>
-					<!-- "in" used in logic tag [instead of contains] -->
+					<!-- "in" used in logic tag [instead of contains, not inside double quotes] -->
 					<dict>
 						<key>captures</key>
 						<dict>
 							</dict>
 						</dict>
 						<key>match</key>
-						<string>(?&lt;=if|unless|elsif)[^%}]+[a-zA-Z0-9\-\w]+\s(in)\s[a-zA-Z0-9\-\w]+</string>
+						<string>(?&lt;=if|unless|elsif)[^%}]+[a-zA-Z0-9\-\w]+\s(in(?=([^'"]*['"][^'"]*['"])*[^'"]*$))\s[a-zA-Z0-9\-\w]+</string>
 					</dict>
 					<!-- illegal equality test in logic tag [broken] -->
 					<dict>
Add a comment to this file

Syntaxes/HTML (Liquid).tmLanguage.cache

Binary file modified.

Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.