Misleading test name in about_class_attributes.py

Giulio Piancastelli avatarGiulio Piancastelli created an issue

The section of about_class_attributes.py dealing with Dog2 contains a test_staticmethods_also_overshadow_instance_methods with a misleading name that seems to imply a precedence of static methods over instance methods in the name resolution process for methods in Python classes. It is not so. In the test, the static method overwrites the instance method only because the former appears after the latter in the class code. If bark(self) appeared after bark(), you would obtain the opposite result.

Proof:

>>> class B(object):
...   @staticmethod
...   def m():
...     return 'm_static'
...   def m(self):
...     return 'm_instance'
... 
>>> b = B()
>>> b.m()
'm_instance'

I would suggest to remove the test, or to morph it into a test on name resolution precedence (the last definition always wins) in the class namespace.

Comments (0)

  1. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.