Chris Moffitt avatar Chris Moffitt committed 998b294

Speedup saves for ProductVariations. Closes #1312

Comments (0)

Files changed (1)

satchmo/apps/product/modules/configurable/models.py

 
         pvs = ProductVariation.objects.filter(parent=self.parent)
         pvs = pvs.exclude(product=self.product)
-        for pv in pvs:
-            if pv.unique_option_ids == self.unique_option_ids:
-                return # Don't allow duplicates
+        for option in self.options.all():
+            pvs = pvs.filter(options__option_group__id=option.option_group_id, 
+                options__value=option.value)
+        if pvs.count():
+            return # Don't allow duplicates
 
         if not self.product.name:
             # will force calculation of default name
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.