Add capability for automatically including -f for ?setship and ?setfreq
Issue #6
resolved
Bots would benefit from a capman capability to automatically include -f on ?setship and ?setfreq.
Suggested by Hakaku here: http://forums.minegoboom.com/viewtopic.php?t=8483
Comments (6)
-
Account Deleted -
Account Deleted - removed version
Removing version: 1.5.0 (automated comment)
-
Account Deleted - changed milestone to 1.5.0rc1
-
- attached forcesetshipsetfreq-patch.txt
This patch adds the capability "forceshipfreqchange"
-
Account Deleted Applied patch in Wiki macro error: Changeset 084938aa31f4 not found..
-
Account Deleted - changed status to resolved
- Log in to comment
pasting original discussion from old issue tracker:
numpf: It was requested that *setship and *setfreq should also be subject to the arena's freq manager, so that even mods couldn't set someone to a ship or freq disallowed by the manager. I disagree, and I think it's potentially useful to let *setship and *setfreq override the freq manager.
What could be done, though, is to name *set{ship,freq} subject to the manager, and then add *sset{ship,freq} (for super-set{ship,freq}), that bypass it.
---
dr brain: I've always been partial to -switches myself. So rather than ?ssetship 4 you could use ?setship -f 4. Just a suggestion.
---
Smong: Re-opening: sgcompat needs updating so bots automatically use the new -f flag, otherwise it will break some bots.
---
numpf: The bots were broken in PB _without_ this fix, when ?setship acted as if it always had the -f flag. *setship in subgame respects at least the FrequencyShipTypes and the ForceEvenTeams settings, and assigns all players to a public freq if they changing to a ship on the spec freq. The alternative fix we had used was hardcoding those rules into game.c, which doesn't seem appropriate.
Is there a known (and preferrably tested) example of a bot that would break? Please post a link or description if so.