?putmap

Issue #73 resolved
hakaku created an issue

If a user is uploading a map to the server and subsequently changes arena before the uploading process is completed, the file will replace the current arena's map, effectively bypassing any arena-restricted uploading powers.

i.e.

?putmap map.lvl (command is used in subarena)

?go (player changes arena, the new map is added to this new arena)

Comments (3)

  1. hakaku reporter

    The offending line is this one:

    http://bitbucket.org/grelminar/asss/src/tip/src/core/admincmd.c#cl-220

    It's retrieving the player's current arena. A way to solve this would be to add Arena *arena into the upload struct (http://bitbucket.org/grelminar/asss/src/tip/src/core/admincmd.c#cl-145 ), and save the player's arena at the time he uses ?putmap using u->arena = p->arena; (http://bitbucket.org/grelminar/asss/src/tip/src/core/admincmd.c#cl-334 ), and finally replace u->p->arena->cfg with u->arena->cfg.

    I haven't tested this yet, but it should work.

  2. Log in to comment