?putfile/?getfile are hilarious but they could be better

Issue #81 new
Justin Schwartz created an issue

These commands are sysop only and should only be had by sysops, unless:

There were capabilities for reading/writing passwd.conf reading/writing global.conf (mysql, billing, etc. passwords) reading/writing staff.conf reading/writing groupdef.conf reading/writing anything in groupdef.dir reading/writing anything in bin/

Possibly also restrict to a global-conf path-regex but then add just one capability for sysops to be able to upload anywhere.

Comments (4)

  1. Joris

    Do non-sysops even need to write outside the arena folder?

    Perhaps something like ?putarenafile and ?getarenafile would be enough

  2. Justin Schwartz reporter

    Sure, maybe I would want to give access to maps/ or conf/subfolder. Keeping literally everything in arenas/ is bad practice.

  3. Justin Schwartz reporter

    Don't you mean "I made a fix" since this issue was reported far before that was released? :p There seem to be a lot of issues with that solution, mostly the shameless nature of using hacks and the completely different style of code from the rest of the core (not to mention thelackofspacesinexpressions.) At the very least you should consolidate all of the stuff together with the existing core module (admincmd?)

    What exactly is the purpose of ?amakearena?

  4. Log in to comment