Pull requests

#1 Open
Repository
spanasik spanasik
Branch
default
Repository
grigi grigi
Branch
default

PEP8

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r default https://bitbucket.org/spanasik/django-galeria
hg merge ca11490a9003
hg commit -m 'Merged in spanasik/django-galeria (pull request #1)'
Author
  1. Stanislav Panasik
Reviewers
Description

Hi!,

This commit makes project PEP8-compatible.

Best regards, Stanislav

Comments (3)

  1. Nickolas Grigoriadis repo owner

    Hi Stanislav

    There is a few issues with this:

    1. I forked this off Guilhermes branch, which is the main one. He wrote the majority of the code

    2. Making code strictly PEP8 compliant for PEP8's sake isn't cool. e.g. Using URL shorteners, or adjusting comments to wrap because they go barely over some arbritary 80-char width by one character makes readability worse. But this isn't my project, so my opinons on this isn't entierly valid.

    The commit about making it work on MySQL seems perfectly valid to me, though.

    I'll get Guilherme to have a look at this.

    Regards, Nickolas

  2. Guilherme Gondim

    I like PEP8 but I don't like be so strict. I don't like function headers in two or more lines for example, neither care about the urls.py... Almost all your changes are valid, but I made some comments about my personal preferences that, IMHO, helps the readability.

    When PEP8 harm too much the readability, I avoid it.

    All your changes are ok, but if you like my suggestions could you change it for us? Afterwards I can give a look as well and change what I don't like and try put in some form that fit in PEP8 too. That not mean my way is the best one, if you disagree with me in some coding style just give your opinion so we can try reach a consensus.

    (Give a look in Django's coding style as well: https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/ :-)

    Thank you!