Keep approvals on Rebase/Amend

[Darren Nolan]

Hi,

We love your plugin, but we do enforce in our workflows that when code changes in PRs, all approvals are automatically removed.

However in the case of using this plugin when developers amend/rebase and the result is not conflicting with the original branch, we would love to see approvals stay.

Is it possible for this plugin to keep approvals in those scenarios?

[Julius Davies [bit-booster.com]]

It's not a problem with Bit-Booster. It's a problem with the free "Auto Unapprove Plugin". Update your "Auto Unapprove Plugin" to its latest version. That should fix it!

https://marketplace.atlassian.com/plugins/com.atlassian.stash.plugin.stash-auto-unapprove-plugin/server/versionhistory

[Darren Nolan]

Seems we have the latest "Auto Unapprove Plugin", but there was an update for BitBooster.

The Auto Unapprove Plugin provided by Atlassian doesn't really seem to offer many options (other than just enable/disable), and I still think our PRs are going to be unapproved when someone uses the rebase/squash buttons based on the change in commit history.

[Darren Nolan]

(I'm going to take a look and see what's what in a test PR)

[Julius Davies [bit-booster.com]]

Hmm, I'll try testing with latest version of Bit-Booster to see if there's a problem afterall. What version of Bitbucket itself are you on?

[Darren Nolan]

v4.11.0

I just hit squash on a PR. The approvals are still there!!!! This is amazing! Fantastic! Thank you! So it was something weird between our versions previously, updating BitBooster plugin seems to have resolved this.