- changed status to resolved
Approvals not removed when PR is declined and re-opened.
Issue #55
resolved
Hi,
Today I discovered that you can prevent PR-Booster from removing approvals by declining your PR, pushing new changes and then re-opening the PR. The approvals stay. Is it possible to check for new commits/changes when a PR is reopened, or have an option to always remove all approvals when a PR is declined and/or reopened to prevent this? Thank you! :)
Comments (2)
-
repo owner -
reporter That was quick, thank you! :)
- Log in to comment
Thanks for the bug report!
Version 2018.11.14 released just now with a fix for this: all approvals will always be dropped upon "re-open" of a declined pull-request.
(Note: the approvals are dropped even if the source branch has not received any commits since the decline happened).