load testing - amend sometimes returns spurious error message

Under very high load in a clustered environment (e.g., 10+ amends/per-second against the same repository) amend would sometimes return with "invalid object: refs/heads/master - repository moved", and yet the amend would still succeed.

We should detect this cosmetic warning and swallow it, since it's just going to upset users who have actually successfully completed an amend operation.

It's cosmetic for two reasons:

1.) The amend actually succeeds.

2.) refs/heads/master inside our temporary PR-Booster clone doesn't even matter - only the remotes actually matter (origin and all forks).

Note: I suspect this bug might be specific to the Atlassian supplied load tests for DC certification - perhaps they are letting 'master' be a source branch in various synthetic PR's, and this causes our amend/squash tests to later force-push against 'master' - this would be highly unusual in a typical corporate setup.

Comments (1)