Failed to calculate patch-ids (Rebase resets approvals)
After updating to 2019.07.03-bb5, PR-Booster no longer preserves approvals when "Automatically Withdraw Approvals" is set to "Yes - For significant pushes" after a server-side Rebase is performed. I don't recall exactly which version of PR-Booster was previously being used (possibly 2019.01.15), but server-side rebases prior to the update did preserve approvals.
The following stacktrace started appearing in atlassian-bitbucket.log
following the update:
#!
2019-07-03 10:49:20,222 WARN [AtlassianEvent::thread-3] c.bitbooster.impl.GitRescopeAnalyzer Failed to calculate patch-ids
com.atlassian.bitbucket.scm.CommandUsageException: The syntax used for the command is incorrect.
at com.atlassian.bitbucket.scm.git.command.GitCommandExitHandler.checkUsage(GitCommandExitHandler.java:60)
at com.atlassian.bitbucket.scm.git.command.GitCommandExitHandler.evaluateStdErr(GitCommandExitHandler.java:66)
at com.atlassian.bitbucket.scm.git.command.GitCommandExitHandler.onError(GitCommandExitHandler.java:197)
at com.atlassian.bitbucket.scm.DefaultCommandExitHandler.onExit(DefaultCommandExitHandler.java:31)
at com.atlassian.bitbucket.scm.BaseCommand.callExitHandler(BaseCommand.java:146)
at com.atlassian.bitbucket.scm.BaseCommand$CommandFuture.internalGet(BaseCommand.java:280)
at com.atlassian.bitbucket.scm.BaseCommand$CommandFuture.get(BaseCommand.java:244)
at com.atlassian.bitbucket.scm.BaseCommand.call(BaseCommand.java:83)
at ca.bitbooster.impl.GitRescopeAnalyzer.calculatePatchId(GitRescopeAnalyzer.java:143)
at ca.bitbooster.impl.GitRescopeAnalyzer.isUpdated(GitRescopeAnalyzer.java:95)
at ca.bitbooster.impl.BBRescopeListenerImpl.onRescope(BBRescopeListenerImpl.java:166)
at com.atlassian.event.internal.SingleParameterMethodListenerInvoker.invoke(SingleParameterMethodListenerInvoker.java:40)
at com.atlassian.stash.internal.event.AsyncBatchingInvokersTransformer$AsyncInvokerBatch.invoke(AsyncBatchingInvokersTransformer.java:109)
at com.atlassian.event.internal.AsynchronousAbleEventDispatcher$1$1.run(AsynchronousAbleEventDispatcher.java:38)
at com.atlassian.sal.core.executor.ThreadLocalDelegateRunnable.run(ThreadLocalDelegateRunnable.java:34)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.lang.Thread.run(Thread.java:745)
... 5 frames trimmed
Comments (5)
-
-
repo owner - changed status to resolved
Fantastic bug report! We’re on it!
-
repo owner
Should be fixed in version v2019.07.08-bb5 of PR-Booster (just published to marketplace.atlassian.com moments ago).
Thanks for the bug report! The fact you included “git version 1.9.5” in your bug report was particularly helpful.
-
repo owner When you confirm this is fixed for your environment (with v2019.07.08-bb5) I’ll close this ticket. But no rush, and again, thank you for a fantastic bug report.
-
repo owner - changed status to closed
- Log in to comment
Sorry, I wasn’t logged in, but I’m the reporter of this issue.
Some details I left out of the issue: