- edited description
timing scripts
Are now not built since we added CmakeLists.txt in tests directory. What to do? Can't be part of make check... Separate "timing" directory?
Comments (7)
-
reporter -
Oops, yes looks like I did not update this with the CMake subdirectory change. Most of the timing scripts I think have not been touched in ages. Should we clean them out? I can fix the CMake code to make them build...
-
reporter I think they have to be in separate directories, otherwise they get included in make check. I definitely don't want to lose them. Maybe one new top-level directory "timing", next to "tests" ?
-
reporter And a "make timing: target?
-
Ok, that sounds like a good idea.
-
This is almost done... I got busy the past couple weeks, but I think I can create a pull request for this this weekend.
-
- changed status to resolved
Resolved with pull request 17 (https://bitbucket.org/gtborg/gtsam/pull-request/17/fix-and-re-enable-building-of-timing/diff)
- Log in to comment