Fix MATLAB examples
All examples in the gtsam_examples demo work, but I have not fixed all others yet. Mainly changing occurrences of at
to atPose2
etc...
Assigning to @lvzhaoyang so he can appreciate the awesomeness of the MATLAB toolbox.
Comments (13)
-
reporter -
Sure. I am looking into that.
-
reporter - changed milestone to GTSAM 4 Roadmap: Modernization
-
reporter So ?
-
Sorry, a project deadline ate my time. I will try to fix this today.
-
reporter Note this is about examples, not tests. Do all examples work?
-
gtsam_examples and gtsam_tests all work, except the testSerialization.
I write the wrapper with a simple solution. It can run without any errors. But the chart values are hard coded.
-
In matlab_example_wrapper branch, I have committed all the fixes in issues, but now with something I current need help to solve.
In gtsam_examples, all matlab examples work, except
-
IMUKittiExampleGPS.m. It is caused by priorFactorVector, which we have finished solving last time. See Commit
-
Pose2SLAMwSPCG.m: now issue #188
In gtsam_tests, all other matlab files work, except:
-
testPriorFactor.m: same issue as IMUKittiExampleGPS.m Commit
-
testSerialization.m: now issue #182.
-
testThinTree.m: GaussianConditional issue, now issue #189
In unstable_examples,
- IMUKittiExampleAdvanced.m: now the same priorFactorVector issue Commit
-
-
reporter Working on a proposal. Will take a look tomorrow..
-
reporter @lvzhaoyang , I don't have time now to look at this. Can you try to fix it yourself? As you know, we just need to emit the unwrap for EIGEN arguments, not unwrap_shared_ptr.
-
No problem. I tried but didn't succeed the last time. I am having two exams Wednesday and Thursday. I will fix this immediately when I finish them.
-
reporter If this is done, please resolve.
-
- changed status to resolved
Resolve matlab examples and merged into develop
- Log in to comment
@lvzhaoyang could you create a branch and fix these, then do a pull request so we can close this issue?