Fix MATLAB examples

Issue #146 resolved
Frank Dellaert created an issue

All examples in the gtsam_examples demo work, but I have not fixed all others yet. Mainly changing occurrences of at to atPose2 etc... Assigning to @lvzhaoyang so he can appreciate the awesomeness of the MATLAB toolbox.

Comments (13)

  1. Frank Dellaert reporter

    @lvzhaoyang could you create a branch and fix these, then do a pull request so we can close this issue?

  2. Zhaoyang Lv

    gtsam_examples and gtsam_tests all work, except the testSerialization.

    I write the wrapper with a simple solution. It can run without any errors. But the chart values are hard coded.

  3. Zhaoyang Lv

    In matlab_example_wrapper branch, I have committed all the fixes in issues, but now with something I current need help to solve.

    In gtsam_examples, all matlab examples work, except

    1. IMUKittiExampleGPS.m. It is caused by priorFactorVector, which we have finished solving last time. See Commit

    2. Pose2SLAMwSPCG.m: now issue #188

    In gtsam_tests, all other matlab files work, except:

    1. testPriorFactor.m: same issue as IMUKittiExampleGPS.m Commit

    2. testSerialization.m: now issue #182.

    3. testThinTree.m: GaussianConditional issue, now issue #189

    In unstable_examples,

    1. IMUKittiExampleAdvanced.m: now the same priorFactorVector issue Commit
  4. Frank Dellaert reporter

    @lvzhaoyang , I don't have time now to look at this. Can you try to fix it yourself? As you know, we just need to emit the unwrap for EIGEN arguments, not unwrap_shared_ptr.

  5. Zhaoyang Lv

    No problem. I tried but didn't succeed the last time. I am having two exams Wednesday and Thursday. I will fix this immediately when I finish them.

  6. Log in to comment