LieVector and LieScalar
I remembered @dellaert said these classes are not needed anymore in 4.0 but their headers still exist. Should we remove them or they are there for backward compatibility?
Comments (8)
-
-
That's correct. @thduynguyen could you add the oxygen deprecated markup and maybe the comment "LieScalar, LieVector and LieMatrix are obsolete in GTSAM 4.0 as we can directly add double, Vector, and Matrix into values now, because of guts::traits."
-
@thduynguyen please do this small doc job so we can close another issue :-)
-
@thduynguyen Also, we have a wiki page about how to transfer from GTSAM 3.X to 4.0. https://bitbucket.org/gtborg/gtsam/wiki/Fix%20Compatibility%20Issues%20from%20GTSAM%203.X%20to%20GTSAM%204.0
I haven't touched LieScalar and LieVector part, it will be great if you could also add in this page. Thanks :)
-
@duy this is still yours...
-
-
assigned issue to
- marked as minor
- changed milestone to GTSAM 4 Roadmap: Modernization
-
assigned issue to
-
-
- changed status to resolved
In pull request #62, thanks @cforster !
- Log in to comment
For compatibility to older version I think we might need to keep this? Since once they are removed many user code need to be changed... but we should definitely mark them as deprecated.