Move print/equals in GenericValue
Issue #190
resolved
This stuff:
// equals for Matrix types
template<int _Rows, int _Cols, int _Options, int _MaxRows, int _MaxCols>
struct equals<Eigen::Matrix<double, _Rows, _Cols, _Options, _MaxRows, _MaxCols> > {
typedef Eigen::Matrix<double, _Rows, _Cols, _Options, _MaxRows, _MaxCols> type;
typedef bool result_type;
bool operator()(const type& A, const type& B, double tol) {
return equal_with_abs_tol(A, B, tol);
}
};
is really part of the Testable concept, and should be moved to Matrix.h (as should stuff in Manifold.h). Can possibly be done in pull request #64?
Comments (3)
-
reporter -
reporter Or, rather than merge, move Value to deprecated ( @cforster , @cbeall3 ?) and make GenericValue the only thing underlying Values.
-
reporter - changed status to resolved
Resolved in pull request #64
- Log in to comment
In fact, @ptf and @mikebosse looking at the whole Value thing, after we implement the proposals in pull request #64, do we still need ChartValue etc? And Value and GenericValue can probably be merged, simply requiring Testable and Serializable (does that already exist in boost?)