Remove ChartValue
Issue #191
resolved
I think we settled in earlier discussions on implementing this type of functionality with expressions and constraints, right? Then do we still need ChartValue and the corresponding complexity in Values? I thought we settled on no, but pls feel free to discuss here, @ptf and @mikebosse
Recap:
- You can use an expression to get the same behavior as a custom chart, esp. now that we agreed they all have to behave like expmap/logmap at identity.
- A linear constraint can be implemented simply by using a Constrained noiseModel. @thduynguyen is there a way to merge in LinearConstraintFactor from your branch in isolation? Or is the QP branch done and we can merge the whole thing?
In any case, if we agree on the above, then the ChartValue experiment leaves in a lot of complex, not well exercised code that should be removed.
Comments (3)
-
reporter -
I thought chart value was already gone. there is just the generic value template. so yes go ahead and remove the chart value files
-
reporter - changed status to resolved
Commit c816c332
- Log in to comment
@mikebosse are you ok with this? If you're too busy I can simply remove.