GtsamPrinting.cmake removed

Issue #438 on hold
Varun Agrawal created an issue

As per commit #c629339, the GtsamPrinting.cmake file was removed from the install list. This is causing CMake errors in various downstream repos.

Can we understand the reason for the removal and accordingly update the other code bases?

Comments (9)

  1. Varun Agrawal reporter

    Would it make sense to add this in again? For some reason, it seems like a lot of GTSAM dependent projects expect that Printing.cmake file. :/

  2. Varun Agrawal reporter

    @richardroberts I'd like to close this but we need to figure out if it makes sense to keep GtsamPrinting.cmake excluded or to include it again since it just seems to be used for cmake message printing.

    @dellaert can you please weigh in too?

  3. Frank Dellaert

    As per commit #c629339, the GtsamPrinting.cmake file was removed from the install list. This is causing CMake errors in various downstream repos.

    Can we understand the reason for the removal and accordingly update the other code bases?

  4. Varun Agrawal reporter

    It would seem that adding the cmake file back into the repo would be the easiest fix. Either that or get rid of this dependence altogether since it seems to be only a utility for printing during CMake operations.

  5. Log in to comment