- marked as trivial
GtsamPrinting.cmake removed
As per commit #c629339, the GtsamPrinting.cmake
file was removed from the install list.
This is causing CMake errors in various downstream repos.
Can we understand the reason for the removal and accordingly update the other code bases?
Comments (9)
-
reporter -
Hi Varun, I'm sorry, I don't know, it was ages ago!
-
reporter Would it make sense to add this in again? For some reason, it seems like a lot of GTSAM dependent projects expect that
Printing.cmake
file. :/ -
reporter @richardroberts I'd like to close this but we need to figure out if it makes sense to keep GtsamPrinting.cmake excluded or to include it again since it just seems to be used for cmake message printing.
@dellaert can you please weigh in too?
-
If the other repos want it just add it again.
-
@varunagrawal is this resolved?
-
-
assigned issue to
As per commit #c629339, the
GtsamPrinting.cmake
file was removed from the install list. This is causing CMake errors in various downstream repos.Can we understand the reason for the removal and accordingly update the other code bases?
-
assigned issue to
-
- changed status to on hold
Putting all issues we want to revisit on github “on hold”
-
reporter It would seem that adding the cmake file back into the repo would be the easiest fix. Either that or get rid of this dependence altogether since it seems to be only a utility for printing during CMake operations.
- Log in to comment