#277 Merged at a5844cb
Repository
Branch
feature/LPSolver
Repository
Branch
develop
Author
  1. Ivan Jimenez
Reviewers
Description
  • [TEST] QP Now correctly handles negative constant values on hessian factors.
  • [BUGFIX] Now handles zero default on QPS files.
  • [TEST] Now includes a test with QPS ranges [FEATURE] Parser Reads but doesn't handle ranges in QPS files.
  • [FEATURE] Raw QP Untested handling of Ranges.

  • [TEST] HS118 no also tests for correctness of actual solution found. Removed debug statements. QPS files with ranges now work correctly.

  • Forgot to add as a vector instead of a double.

  • [TEST] Add HS35 [TEST] Disabled HS118

  • [TEST] Added Test HS35MOD [FEATURE] Added support for FX bounds for QPS Parsing format.

  • [TEST] Added Remaining Failing Tests AUG2D CONT-050 HS118 HS268 HS51 HS51 HS53 HS76

  • [TEST] added QPTest. Showcases failure to work on indeterminate linear systems.

  • Commit status

Comments (26)

  1. Frank Dellaert

    @ivandariojr could you pul latest git, merge in develop, and run all tests again? Jenkins never cleared this branch, but it would be good to resolve any issues and merge, in our latest housekeeping push.

  2. Frank Dellaert

    Pipeline fails still:

    185/230 Test #185: testQPSolver ...........................***Failed    0.01 sec
    /opt/atlassian/pipelines/agent/build/gtsam_unstable/linear/tests/testQPSolver.cpp:314: Failure: "Exception: 
    Indeterminant linear system detected while working near variable
    6341068275337658369 (Symbol: X1).
    Thrown when a linear system is ill-posed.  The most common cause for this
    error is having underconstrained variables.  Mathematically, the system is
    underdetermined.  See the GTSAM Doxygen documentation at
    http://borg.cc.gatech.edu/ on gtsam::IndeterminantLinearSystemException for
    more information." 
    /opt/atlassian/pipelines/agent/build/gtsam_unstable/linear/tests/testQPSolver.cpp:322: Failure: "Exception: 
    Indeterminant linear system detected while working near variable
    6341068275337658369 (Symbol: X1).
    Thrown when a linear system is ill-posed.  The most common cause for this
    error is having underconstrained variables.  Mathematically, the system is
    underdetermined.  See the GTSAM Doxygen documentation at
    http://borg.cc.gatech.edu/ on gtsam::IndeterminantLinearSystemException for
    more information." 
    There were 2 failures
    
  3. Ivan Jimenez

    It’s getting indeterminant linear system errors in Release but not on debug. I am investigating now.

  4. Frank Dellaert

    Added a couple of comments. BTW, What is the size of all those QPS files? GTSAM download/clone is way bigger than it should be. If they are not being used, consider removing them. I also saw some tests being disabled as “too” large. Until we find a way o make them run, I’d advocate for creating a separate branch in which those tests are enabled and those files exists, but they are removed from develop (both tests and corresponding QPS files).

  5. Frank Dellaert

    @ivandariojr take a look at latest commit. I removed Visitor as a separate compilation unit. Is the indirection/passthrough in parser really needed? Is there a simplification for this?