Move kx connections related arrays to kt_grids?

Issue #245 new
David Dickinson created an issue

Recent work in PR #796 - PR #804 has split the initialisation of the connected boundaries into distinct subroutines. Several of these simply depend on kt_grids and theta_grid so these routines could be moved to kt_grids and unconditionally calculated.

To be explicit we could move:

  • compute_jshift0
  • compute_itleft_and_itright
  • count_links_one_side
  • count_links

To kt_grids along with the associated arrays which can then be used from other places. As noted in PR #806 this should give enough information to detect if there are any connections and hence if there’s any point in actually setting up the rest of the linked boundary conditions. One could imagine skipping most/all of init_connected_bc in such an instance.

We could also move setup_fields_implicit_class_arrays to fields_implicit

Comments (0)

  1. Log in to comment