Possible CFL mistake in NL terms?

Issue #260 resolved
David Dickinson created an issue

In nonlinear terms we calculate the cfl limit in x and y from the real space potential gradients. For example:

https://bitbucket.org/gyrokinetics/gs2/src/e29e9ab8f2eb8d01292fee68588b8bbed560e00b/src/nonlinear_terms.fpp#lines-844

Note here we pass cfly after calculating i kx chi and cflx after calculating i ky chi. Maybe I’m missing something obvious, but I think this is probably the wrong way around? Any thoughts @Colin Malcolm Roach ?

Comments (4)

  1. David Dickinson reporter

    Ah yes of course, should have thought about it for five more minutes. The velocity ~ v_ExB → The x-component of the velocity uses E_y

  2. Log in to comment