Ancient Deprecation Warning
Issue #35
resolved
When compiling and running the test suite, the gs2 diagnostics test still emits a warning about the old diagnostics module. It claims said code will have been removed from the codebase circa 2015.
Did this happen? :)
If not, it probably ought to. Or we should just admit we'll never remove the code and start supporting the old diagnostics again.
If it did, why on earth is gs2-diagnostics-test bleating about this.
Mainly posting this bug as a reminder to myself to go and look at this some more.
Comments (4)
-
-
I believe the new diagnostic routines were built with up-to-date compiler capabilities. The initial optimism reflected in the warning ran aground as we try to support out-of-date users (like me). The old routines should be kept for a while longer.
The warning, however, could be deleted forthwith.
-
I agree we should remove this warning and I think the evolution of the diagnostic code will need careful thought and discussion.
-
- changed status to resolved
Resolved by PR #50
- Log in to comment
I think we probably want to keep this code around for a bit longer but I think we should remove the warning for now and reintroduce it if/when we decide to proceed.
With the new more formal work flow it should be clearer when we should introduce such deprecation warnings and when we can remove them (generally the warning should appear in master one significant release before the release which removes the feature).